hashicorp / terraform-provider-google

Terraform Provider for Google Cloud Platform
https://registry.terraform.io/providers/hashicorp/google/latest/docs
Mozilla Public License 2.0
2.29k stars 1.72k forks source link

Failing test(s): TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule #19086

Open melinath opened 1 month ago

melinath commented 1 month ago

Impacted tests

Affected Resource(s)

Failure rates

Message(s)

Error: Error creating OrganizationEventThreatDetectionCustomModule: googleapi: Error 409: failed to create module due to concurrent modification

Possibly this indicates a need for a mutex and/or serializing these tests.

Nightly build test history

b/358692342

ScottSuarez commented 3 weeks ago

Still seeing failures here https://hashicorp.teamcity.com/test/-224300369035462042?currentProjectId=TerraformProviders_GoogleCloud_GOOGLE_BETA_NIGHTLYTESTS&expandTestHistoryChartSection=true

=== RUN   TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule
=== PAUSE TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule
=== CONT  TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule
    vcr_utils.go:152: Step 1/4 error: Error running apply: exit status 1
        Error: Error creating OrganizationEventThreatDetectionCustomModule: googleapi: Error 409: failed to create module due to concurrent modification
          with google_scc_management_organization_event_threat_detection_custom_module.example,
          on terraform_plugin_test.tf line 2, in resource "google_scc_management_organization_event_threat_detection_custom_module" "example":
           2: resource "google_scc_management_organization_event_threat_detection_custom_module" "example" {
--- FAIL: TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule (6.35s)
FAIL

I suspect that since this runs in GA and BETA but is an ORG level test this is where the concurrent modification fails out? We should likely only run this test in one environment (if that is the problem).

ScottSuarez commented 3 weeks ago

Actually.. I'm going to continue to keep a pulse on this. Since the change has only been checked in recently I'll let this play out a bit more.

ScottSuarez commented 1 week ago

Another failure today, un-assigning myself