add aclEnabled to google_discovery_engine_data_store

[eeaton]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
• Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.
• If an issue is assigned to a user, that user is claiming responsibility for the issue.
• Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

The google_discovery_engine_data_store resource in Terraform has no way to set use the GA feature configure data source access control.

Currently, the aclEnabled flag can only be enabled when creating a data store through the UI or through a direct API call (no support for gcloud or terraform). It should be added as an optional

New or Affected Resource(s)

• google_discovery_engine_data_store

Potential Terraform Configuration

Example implementation with a new boolean argument exposed for aclEnabled

resource "google_discovery_engine_data_store" "basic" {
  location                     = "global"
  data_store_id                = "data-store-id"
  display_name                 = "tf-test-structured-datastore"
  acl_enabled = true
  industry_vertical            = "GENERIC"
  content_config               = "NO_CONTENT"
  solution_types               = ["SOLUTION_TYPE_SEARCH"]
  create_advanced_site_search  = false
  skip_default_schema_creation = false
}

References

No response

b/369148147

[BBBmau]

Hi @eeaton, based off of the API Docs it is currently unsupported yet. Do you know where else this field is called or if this field has yet to be added into the official API Docs?

[eeaton]

Hmm, the product docs claim that this is supported in the API, but that's concerning that it's not included in the API docs.

Screenshot of relevant section of product docs that mentions the aclEnabled flag:

I've raised an internal bug with the product team to confirm, b/369297665.