hashicorp / terraform-provider-google

Terraform Provider for Google Cloud Platform
https://registry.terraform.io/providers/hashicorp/google/latest/docs
Mozilla Public License 2.0
2.32k stars 1.72k forks source link

Add reservation_sharing_policy argument to compute_reservation resource #19635

Open Alex-Bubblemaster opened 2 weeks ago

Alex-Bubblemaster commented 2 weeks ago

Community Note

Description

The reservation sharing policy allows sharing a reservation with Vertex training and prediction. We can already achieve this via the console, gcloud and API and would like to request the attribute to be added to the compute_reservation_resource so we can continue sharing the reservation using Terraform

https://cloud.google.com/compute/docs/instances/reservations-modify#modify-sharing-policy

New or Affected Resource(s)

Potential Terraform Configuration

resource "google_compute_reservation" "gce_reservation" {
  name = "gce-reservation"
  zone = "us-central1-a"
  reservation_sharing_policy {
     service_share_type = "ALLOW_ALL"
  }
}

References

No response

b/372032982

SarahFrench commented 1 week ago

Note from triage: I can see that reservation_sharing_policy is a new field that's currently only in the Beta version of the Compute API. We should add support for that field and its nested fields.