search

hashicorp / terraform-provider-google

Terraform Provider for Google Cloud Platform
https://registry.terraform.io/providers/hashicorp/google/latest/docs
Mozilla Public License 2.0
2.36k stars 1.75k forks source link

pubsub: additional test permissions fixes #20312

Closed modular-magician closed 1 week ago

modular-magician commented 1 week ago

Remove duplicated permissions, and work around terraform depends_on with some additional logic.

Rename terraform resources bigquery_foo_xxx instead of just editor / viewer, to avoid confusion with project viewer / editor roles.

Followup to #12095

I am pretty sure this will fix the last item; left the other two marked as "part of" in case this doesn't resolve those, but since those the two generated tests have test_vars_overrides for bootstrapping that this would have interfered with, hopefully this helps with any such issues.

Part of hashicorp/terraform-provider-google#20274 Part of hashicorp/terraform-provider-google#20262 Fixes hashicorp/terraform-provider-google#20261

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Derived from https://github.com/GoogleCloudPlatform/magic-modules/pull/12311