In future the team may want to revisit this deleted code to inform work to pulls out the SDKv2 from the codebase completely and the provider becomes 100% plugin-framework. As that is a long way in the future I think it's best to delete this code now for clarity. It will still be in version control for reference in the future.
When looking at the deleted code be wary of:
Functions with the same name as SDK code that are functions instead of methods on a struct
Follow up to https://github.com/GoogleCloudPlatform/magic-modules/pull/11903. ~Most commits in this PR are in that PR, and will 'disappear' once this PR is unblocked and ready for review.~ This PR has been rebased to address this!
This PR deletes all the parallel implementations of provider configuration logic. The PR https://github.com/GoogleCloudPlatform/magic-modules/pull/11903 stops the provider using this duplicated logic, and this PR removes that redundant code.
In future the team may want to revisit this deleted code to inform work to pulls out the SDKv2 from the codebase completely and the provider becomes 100% plugin-framework. As that is a long way in the future I think it's best to delete this code now for clarity. It will still be in version control for reference in the future.
When looking at the deleted code be wary of:
Release Note Template for Downstream PRs (will be copied)
Derived from https://github.com/GoogleCloudPlatform/magic-modules/pull/11578