google_monitoring_alert_policy: doesn't support timeWindow

[IRus]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

I'd like to specify Metric rate (percent) of change condition for alert policy with tf

New or Affected Resource(s)

• google_monitoring_alert_policy

Potential Terraform Configuration

resource "google_monitoring_alert_policy" "my_endpoint_p2" {
  display_name = "My Endpoint"
  enabled = true
  combiner = "OR"

  conditions {
    display_name = "Fallback calls count"
    condition_threshold {
      aggregations {
        alignment_period = "60s"
        cross_series_reducer = "REDUCE_SUM"
        per_series_aligner = "ALIGN_PERCENT_CHANGE"
      }
      comparison = "COMPARISON_GT"
      time_window = "300s"
      filter = "metric.type=\"custom.googleapis.com/my/endpoint/http/fallback\" resource.type=\"global\""
      threshold_value = 5
      trigger {
        count = 1
      }
    }
  }

  notification_channels = [...]
}

[IRus]

Export of JSON from stackdriver policy details page

{
  "combiner": "OR",
  "conditions": [
    {
      "conditionRate": {
        "aggregations": [
          {
            "alignmentPeriod": "60s",
            "crossSeriesReducer": "REDUCE_SUM",
            "perSeriesAligner": "ALIGN_MEAN"
          }
        ],
        "comparison": "COMPARISON_GT",
        "filter": "metric.type=\"custom.googleapis.com/my/endpoint/http/fallback\" resource.type=\"global\"",
        "thresholdValue": 5,
        "timeWindow": "300s",
        "trigger": {
          "count": 1
        }
      },
      "displayName": "Fallback calls count"
    }
  ],
  "displayName": "My Endpoint",
  "enabled": true,
  "notificationChannels": [...]
}

[namelessvoid]

I did not look too much into detail but it seems that we also need a condition_rate here (see line 5 in the JSON posted in the previous comment)?

However, the official API documentation does neither cover timeWindow nor conditionRate at time of writing. Maybe this is because google flags the alert policy API as "beta" and does not support rate conditions officially at the moment?

[AlfatahB]

b/262484991

[AlfatahB]

I've looked into this issue and the following are the details that I have found out:

• It seems like this issue wants to add support for the time_window field in the google_monitoring_alert_policy resource.
• As per the JSON shared in the above comment, it looks like the condition is of type conditionRate and it contains the timeWindow field.
• The conditionRate seems not to be supported by the API and it supports only four types of conditions.

Hence, Adding the support for these fields in the terraform requires the API to support these fields as well.