Allow "subnetwork" field of google_dataflow_job to accept self_links and partial URIs

[jcanseco]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

The subnetwork field of google_dataflow_job seems inconsistent with other Terraform reference fields. Currently, the field needs to take the form of regions/REGION/subnetworks/SUBNETWORK, whereas other Terraform reference fields typically take the form of a self_link, partial URI, or shortname. For references to a network for example:

• self_link: www.compute.googleapis.com/projects/PROJECT/global/networks/NETWORK
• partial uri: projects/PROJECT/global/networks/NETWORK
• shortname: NETWORK

We'd like to make an enhancement request that makes the subnetwork field take a format that is more consistent with other reference fields.

New or Affected Resource(s)

• google_dataflow_job

b/359302926

[ggtisc]

Currently the subnetwork argument of google_dataflow_job only accepts the next format as shown in terraform registry:

regions/REGION/subnetworks/SUBNETWORK

For shared VPC networks it needs to have this format: googleapis.com/compute/v1/projects/PROJECT_ID/regions/REGION/subnetworks/SUBNET_NAME

[roaks3]

Note: previous PR attempt was closed due to being stale