google_notebooks_instance should allow for labels on resources automatically created like disks

[cm-wayfair]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Labels are important for billing and resource management. google_notebooks_instance should allow for either declaring of resources attached to notebooks or pass-thru of labels from the parent resource (notebook-comput-instance).

New or Affected Resource(s)

• google_notebooks_instance

Potential Terraform Configuration

labels = {
    can_remove = "true"
  }

References

https://www.terraform.io/docs/providers/google/r/compute_disk.html

• 0000

[danawillow]

Same response here as #7233 - if it's in the API then we can add it to the provider, but in this case it doesn't look like it is: https://cloud.google.com/ai-platform/notebooks/docs/reference/rest/v1beta1/projects.locations.instances.

[gogasca]

1. With respect to tags: tags support is part of API now and TF.

https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/products/notebooks/api.yaml#L375

2. Next week, Notebooks will add the following labels to resources automatically:

Notebook instance "goog-caip-notebook":""
Notebook volume "goog-caip-notebook-volume":""

Can you let us know if this is what you are looking for?

[rragundez]

I believe this is still not in place and my billing has a big chunk unaccounted for because the labels are not propagated to the boot nor the attached disks. Can we add the functionalty to declare labels to disks?

[ggtisc]

Hi @cm-wayfair!

This is an old issue so idk if the labels argument already existed when this issue was created. Just to be sure are you looking to add labels to the boot_disk_type and/or data_disk_type or is it ok with the current labels argument?