Allow pairing_key to accept input when interconnect_attachment type is partner_provider

jfeng-dev commented 3 years ago

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

I'm willing to do the work for this in the Magic Modules

The terraform provider doesn't support an input for the pairing_key field when type is PARTNER_PROVIDER, though type supports value PARTNER_PROVIDER currently. Terraform Doc GCP Doc

There could be a new input key partner_pairing_key to avoid the COMPUTED + OPTIONAL issue that might come up if pairing_key was optional input and sometimes output or empty. Would this be the right path to go down?

The use case would be provisioning interconnect attachments as a Partner Provider. It would complete the workflow initiated by the current PARTNER functionality set up. Admittedly, it's fairly niche.

We might have access to a Partner Interconnect for testing in a few weeks.

New or Affected Resource(s)

google_compute_interconnect_attachment

Potential Terraform Configuration

resource "google_compute_interconnect_attachment" "attachment" {
  name                             = var.name
  router                           = google_compute_router.router.id
  type                             = "PARTNER_PROVIDER"
  partner_pairing_key              = "XXXX/region/domain
}

References

https://github.com/hashicorp/terraform-provider-google/issues/4326 https://github.com/GoogleCloudPlatform/magic-modules/pull/1323 https://github.com/hashicorp/terraform/issues/21278

b/359561794

ggtisc commented 3 months ago

A proposal for the pairing_key argument to be available not only for type PARTNER for the google_compute_interconnect_attachment resource.

roaks3 commented 1 month ago

Note: https://github.com/GoogleCloudPlatform/magic-modules/pull/4480 looks like a feasible solution, but it stalled out due to CLA. Someone may be able to just carry that work forward.

hashicorp / terraform-provider-google