Support GCS backups in google_notebooks_instance

[amarrella]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Creating AI Platform notebooks from the console, it's possible to select a location to backup the data to GCS:

It would be awesome if we could achieve the same via terraform :)

Unfortunately it doesn't seem to be directly supported or documented by the notebooks API, so it must be handled at some other layer.

New or Affected Resource(s)

• google_notebooks_instance

Potential Terraform Configuration

resource "google_notebooks_instance" "instance" {
  name = "notebooks-instance"
  location = "us-west1-a"
  machine_type = "e2-medium"
  vm_image {
    project      = "deeplearning-platform-release"
    image_family = "tf-latest-cpu"
  }
  gcs_backup_location = "gs://bucket/path"
}

b/360937602

[c2thorn]

What this appears to be doing is creating a snapshot of the disk after the instance is created and storing it in a bucket. This would certainly need API support first since the beta API doesn't seem to even return the disk references: https://cloud.google.com/ai-platform/notebooks/docs/reference/rest/v1beta1/projects.locations.instances#DiskType

Marking this as upstream until we have more support from the API.

[jrderuiter]

Is this still blocked by missing API support upstream? (I think so, but not sure if I'm able to judge.)

[ggtisc]

Currently there is an attribute location to achieve this

[roaks3]

location is separate from the ask here. Note though that google_notebooks_instance is now deprecated, however I don't see a backup option on google_workbench_instance either, and it still looks like the API doesn't offer it (as best I can tell).