Ability to create Layer 2 Partner Interconnect

aholyoake-bc commented 3 years ago

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Currently it is impossible to create a layer 2 partner interconnect with bgp fully configured using the terraform google provider. When using a PARTNER interconnect attachment, the interconnect interfaces are automatically created with names such as auto-ia-if-test-sandbo-XXX and there is no ability to subsequently modify the bgp peer settings without resorting to hacks such as this

It is not possible to manually create the interfaces and subsequently associate them with the attachment. It is also not possible (afaik) to retrieve the names of the automatically created interfaces (i.e. via a data provider) so that we can refer to them in other states.

New or Affected Resource(s)

google_compute_router_interface
google_compute_router_peer
google_compute_interconnect_attachment

Potential Terraform Configuration

Given how the underlying API is behaving, I'm not sure what this should look like


resource "google_compute_interconnect_attachment" "test" {
  name                     = test
  admin_enabled      = false
  type                     = "PARTNER"
  router                   = google_compute_router.gcp_router.id
  region                   = var.gcp_region
  edge_availability_domain = "AVAILABILITY_DOMAIN_1"
  bgp_peers {
    peer_asn = ...
  }
}

References

Somewhat related: #7538 (although this requires the name to be known beforehand)
Hacky Solution
GCP Documentation - Definition
GCP Documentation - Configuration (Go to gcloud tab, step 2)

b/359705160 b/359704531

aholyoake-bc commented 3 years ago

I've raised a support ticket with GCP and they have send this issue tracker link https://issuetracker.google.com/issues/150502627

However, at a minimum it would be great to have a gotcha / illustration of a workaround in the provider docs to stop people wasting hours where the problem lies.

Cheers!

ggtisc commented 1 month ago

Currently the type PARTNER is available for google_compute_interconnect_attachment.
It is possible to configure and manage a BGP peer with a management_type.MANAGED_BY_ATTACHMENT attribute of google_compute_router_peer that is configured and managed by Cloud Interconnect, specifically by an InterconnectAttachment of type PARTNER. Google automatically creates, updates, and deletes this type of BGP peer when the PARTNER InterconnectAttachment is created, updated, or deleted.
But there isn't any option to do it with the google_compute_router_interface resource. It needs to be evaluated if it is suitable to do the same with this resource

hashicorp / terraform-provider-google