Validate bigquery reservation name match expected format

[melinath]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Affected Resource(s)

• google_bigquery_reservation

Description

Bigquery reservations can only use alphanumeric characters and dashes. If you try to include something else (like an underscore) you will get the following unhelpful error from the API:

{
  "error": {
    "code": 400,
    "message": "Malformed reservation.",
    "status": "INVALID_ARGUMENT"
  }
}

References

• https://cloud.google.com/bigquery/docs/reference/reservations/rest/v1/projects.locations.reservations/create#query-parameters
• b/188796577

b/359704912

[ggtisc]

Confirmed issue!

This is a proposal to include underscores on the name argument of the google_bigquery_reservation resource

[roaks3]

I think this is actual requesting to validate the existing allowed format, so that underscores (and other disallowed characters) produce a better error.