feat: support Helm DeletionPropagation in Uninstall

adrianmace commented 6 months ago

Description

This PR aims to fix #1363

By passing through the DeletionPropagation value down to the Helm library, we can support the foreground cascading deletion feature of Kubernetes.

Acceptance tests

[ ] Have you added an acceptance test for the functionality being added?

TODO

Release Note

Release note for CHANGELOG:

`helm_release`: Add `deletion_propagation` property to control Kubernetes Cascading Deletion behaviour.

References

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

hashicorp-cla-app[bot] commented 6 months ago

All committers have signed the CLA.

adrianmace commented 6 months ago

Due to my limited knowledge of Golang and the way in which this codebase is structured/tested, I'd be happy to hand this PR over in this state to a maintainer to complete and release the work.

The only elements I was unsure about is test coverage (if required) and if the Schema version needs to be updated due to this additional field.

hashicorp / terraform-provider-helm