hashicorp / terraform-provider-helm

Terraform Helm provider
https://www.terraform.io/docs/providers/helm/
Mozilla Public License 2.0
1.01k stars 371 forks source link

Add new fields to release metadata, fix issue with test suite #1380

Closed danielskowronski closed 5 months ago

danielskowronski commented 5 months ago
  1. Add new computed fields to helm_release.metadata:
    • last_deployed to implement #1374
    • first_deployed and notes to extend functionality further
  2. Fix issue with tests that are using exec.Command to call helm CLI directly - they were expecting kubeconfig to be at $KUBECONFIG, which may not be the same as $KUBE_CONFIG_PATH. The latter is explicitly expected by test suite for Terraform part.

Description

Exposes more metadata about Helm release to extend the possibilities of other resources to act upon release changes. Additionally, provide primitive output from Helm deployment (rendered templates/NOTES.txt if available), which can be used with some bootstrap process.

In other words - adding missing data exposed by Helm.

Acceptance tests

Release Note

Release note for CHANGELOG:

- add new attributes to helm_release.metadata: last_deployed, first_deployed, notes
- fix uses of helm CLI in tests: explictly use $KUBE_CONFIG_PATH

References

Community Note

hashicorp-cla-app[bot] commented 5 months ago

CLA assistant check
All committers have signed the CLA.

appilon commented 5 months ago

Since this PR was so well done I'm going to take the liberty of getting the PR unblocked.