Fix: only recompute metadata when the version in the metadata changes - Githubissues

hashicorp / terraform-provider-helm

Terraform Helm provider

https://www.terraform.io/docs/providers/helm/

Mozilla Public License 2.0

1.01k stars 371 forks source link

Fix: only recompute metadata when the version in the metadata changes #1458

Closed chotiwat closed 2 months ago

chotiwat commented 3 months ago

Description

This PR fixes the issue with metadata getting recomputed due to inexact version attribute, as pointed out by @sheneska in https://github.com/hashicorp/terraform-provider-helm/issues/1344#issuecomment-2025818377

Acceptance tests

[x] Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

`resource/helm_release`: Fix: only recompute metadata when the version in the metadata changes [GH-1344](https://github.com/hashicorp/terraform-provider-helm/issues/1344)

References

https://github.com/hashicorp/terraform-provider-helm/issues/1344 https://github.com/hashicorp/terraform-provider-helm/issues/1150

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

BBBmau commented 3 months ago

@chotiwat can you add in a changelog-entry? I'll be reviewing this PR in the coming days. Thanks!

itay-grudev commented 2 months ago

@BBBmau We are affected by this as it's throwing our CD by constantly producing a false positive change list.