Closed abhinavdahiya closed 4 years ago
I tried this patch, and found that it worked with Terraform version 0.12.7. Per my comment above in file ignition/provider.go, there's no cleanup of the files written by diskv, so it appears that they'll accumulate without bound over time, until rebooting the machine purges the temporary directory. Can you think of a tenable approach to curbing that growth?
I take it we can't purge these files when the program starts, because we may be restarting in the interest of recovering the cache left behind from a previous—and very recent—run of the program.
Now that #56 is committed, it doesn't seem likely that we'll accept this patch, given that it's a different approach to solve the same problem. Shall we abandon this patch?
I believe this issue can be closed now.
With errors like issue 116 1, terraform restarts the provider server. And with terraform turning on
AutoMTLS
for all plugins 2, the client cannot reattach to already running provider server 3.Provider's memory only caches creates errors like
invalid file \"49e2cc7ba023d87070d9b49a0c8f02ff0f63b7f61b390fbce8f64b011bd42ed7\", unknown file id
because the ignition_config resource tried to retrived a file id stored in cache before provider server was restarted.This stores the objects in
diskv
store in users' cache directory, retireving it when the memory cache is not populated. The in-memory cache keeps providing the no overhead access to objects.