search

hashicorp / terraform-provider-ignition

Terraform Ignition provider
https://www.terraform.io/docs/providers/ignition/
Mozilla Public License 2.0
38 stars 64 forks source link

Fix documentation as file and directory mode have same behaviour #58

Closed obourdon closed 4 years ago

obourdon commented 5 years ago

Small changes to add extra space for better readability

Unless I am completely mistaken, both directory and file now supports mode being expressed as octal string. At least if was working perfectly well with octal modes in my last series of tests

obourdon commented 5 years ago

Could someone please review and merge this very easy one ? Many thanks

obourdon commented 5 years ago

Hashicorp team, please, any chance this trivial fix gets reviewed and merged soon ? Many thanks in advance

obourdon commented 5 years ago

@seh just saw that you reviewed another doc issue in this repo. Can you please help ?

obourdon commented 5 years ago

@seh many thanks for your answer. PR code updated accordingly

obourdon commented 5 years ago

@seh many thanks again for your help and review

obourdon commented 4 years ago

@seh do you have any pointers to people who might be able to integrate this into the official doc please ?

seh commented 4 years ago

Only by looking at the most recent committers can we glean who can merge this. It looks like that's @alexsomesan, @appilon, and @pbrit.

obourdon commented 4 years ago

Any progress on this one please ? @pbrit @appilon @alexsomesan Many thanks in advance

obourdon commented 4 years ago

@pbrit @appilon @alexsomesan did you get a chance to have a look in this one ?

obourdon commented 4 years ago

@pbrit @appilon @alexsomesan is it possible to have a look in this one soon please?

obourdon commented 4 years ago

@pbrit @appilon @alexsomesan is it possible to have a look in this one soon please?

obourdon commented 4 years ago

@terraformteam

obourdon commented 4 years ago

@pbrit @appilon @alexsomesan is it possible to have a look in this one soon please?

alexsomesan commented 4 years ago

I‘m away for most of the week but I will look into it once I‘m back.

On Mon 21. Oct 2019 at 08:57, Olivier Bourdon notifications@github.com wrote:

@pbrit https://github.com/pbrit @appilon https://github.com/appilon @alexsomesan https://github.com/alexsomesan is it possible to have a look in this one soon please?

—

You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/terraform-providers/terraform-provider-ignition/pull/58?email_source=notifications&email_token=AAIL5GYUAEAQIXLP6G3SUQDQPVHFXA5CNFSM4H7O6IA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBZIL7I#issuecomment-544376317, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIL5GZFCCGKQG6L3JEFG33QPVHFXANCNFSM4H7O6IAQ .

--

— Sent from my phone.

obourdon commented 4 years ago

@alexsomesan many thanks for your help on this

obourdon commented 4 years ago

@alexsomesan many thanks for integrating this