search

hashicorp / terraform-provider-kubernetes

Terraform Kubernetes provider
https://www.terraform.io/docs/providers/kubernetes/
Mozilla Public License 2.0
1.58k stars 967 forks source link

Add expirationSeconds to CertificateSigningRequest #2515

Closed moreinhardt closed 2 months ago

moreinhardt commented 3 months ago

Description

I saw that expirationSeconds wasn't available through this provider.

Acceptance tests

Output from acceptance testing:

$ make testacc TESTARGS='-run="(TestAccKubernetesCertificateSigningRequestV1_basic|TestAccKubernetesCertificateSigningRequestV1_generateName)"'
==> Checking that code complies with gofmt requirements...
go vet ./...
TF_ACC=1 go test "/home/moritz/dev/terraform-provider-kubernetes/add-fields-to-certificate-signing-request/kubernetes" -v -vet=off -run="(TestAccKubernetesCertificateSigningRequestV1_basic|TestAccKubernetesCertificateSigningRequestV1_generateName)" -parallel 8 -timeout 3h
=== RUN   TestAccKubernetesCertificateSigningRequestV1_basic
=== PAUSE TestAccKubernetesCertificateSigningRequestV1_basic
=== RUN   TestAccKubernetesCertificateSigningRequestV1_generateName
=== PAUSE TestAccKubernetesCertificateSigningRequestV1_generateName
=== CONT  TestAccKubernetesCertificateSigningRequestV1_basic
=== CONT  TestAccKubernetesCertificateSigningRequestV1_generateName
--- PASS: TestAccKubernetesCertificateSigningRequestV1_generateName (3.42s)
--- PASS: TestAccKubernetesCertificateSigningRequestV1_basic (3.43s)
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/kubernetes   (cached)

Release Note

Release note for CHANGELOG:

`resource/kubernetes_certificate_signing_request_v1`: Add argument `spec.expiration_seconds`

References

Community Note

hashicorp-cla-app[bot] commented 3 months ago

CLA assistant check
All committers have signed the CLA.

moreinhardt commented 3 months ago

What do I need to do for this to be merged or as a first step to be looked at by a maintainer?

Also, the acceptance test actions on my fork fail every day which spams me with notifications. Is there any way I can avoid that?

BBBmau commented 2 months ago

Be sure to add a changelog as part of your PR, the steps to do this can be found here: https://github.com/hashicorp/terraform-provider-kubernetes/blob/8ded5dc5338b28f49854d1192f09776ced73e91c/CHANGELOG_GUIDE.md#how-to-use

Deferred Actions workflow can be ignored since they will not pass on PRs from forks. Fix for this is here: https://github.com/hashicorp/terraform-provider-kubernetes/pull/2550

BBBmau commented 2 months ago

Seems like I am unable to make edits on this PR. Since this only needs a changelog entry to be merged and sufficient time has passed with no response, I'll be closing this PR to open a new one with the required changelog entry.