search

hashicorp / terraform-provider-kubernetes

Terraform Kubernetes provider
https://www.terraform.io/docs/providers/kubernetes/
Mozilla Public License 2.0
1.6k stars 979 forks source link

Certificate signing request expiration seconds #2559

Closed BBBmau closed 4 months ago

BBBmau commented 4 months ago

wrapping up https://github.com/hashicorp/terraform-provider-kubernetes/pull/2515

Original Description

Description

I saw that expirationSeconds wasn't available through this provider.

Acceptance tests

Output from acceptance testing:

$ make testacc TESTARGS='-run="(TestAccKubernetesCertificateSigningRequestV1_basic|TestAccKubernetesCertificateSigningRequestV1_generateName)"'
==> Checking that code complies with gofmt requirements...
go vet ./...
TF_ACC=1 go test "/home/moritz/dev/terraform-provider-kubernetes/add-fields-to-certificate-signing-request/kubernetes" -v -vet=off -run="(TestAccKubernetesCertificateSigningRequestV1_basic|TestAccKubernetesCertificateSigningRequestV1_generateName)" -parallel 8 -timeout 3h
=== RUN   TestAccKubernetesCertificateSigningRequestV1_basic
=== PAUSE TestAccKubernetesCertificateSigningRequestV1_basic
=== RUN   TestAccKubernetesCertificateSigningRequestV1_generateName
=== PAUSE TestAccKubernetesCertificateSigningRequestV1_generateName
=== CONT  TestAccKubernetesCertificateSigningRequestV1_basic
=== CONT  TestAccKubernetesCertificateSigningRequestV1_generateName
--- PASS: TestAccKubernetesCertificateSigningRequestV1_generateName (3.42s)
--- PASS: TestAccKubernetesCertificateSigningRequestV1_basic (3.43s)
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/kubernetes   (cached)

Release Note

Release note for CHANGELOG:

`resource/kubernetes_certificate_signing_request_v1`: Add argument `spec.expiration_seconds`

References

Community Note

BBBmau commented 4 months ago

the no documentation label is just to cancel the Document Updates workflow that will need to be addressed in a separate PR.

BBBmau commented 4 months ago

Thanks for contributing! @moreinhardt