hashicorp / terraform-provider-kubernetes

Terraform Kubernetes provider
https://www.terraform.io/docs/providers/kubernetes/
Mozilla Public License 2.0
1.6k stars 979 forks source link

feat: added "strategy.rolling_update.max_surge" argument to `kubernetes_daemon_set_v1` #2609

Closed theonlyames closed 4 days ago

theonlyames commented 4 weeks ago

Description

Adds support for the rollingUpdate.maxSurge property for DaemonSets. See #2106

There is admittedly already a PR for this (PR #2416), but that is slightly out of date in terms of the documentation structure and I started this branch before I realized it existed.

Acceptance tests

Output from acceptance testing:

I am currently struggling to actually run any of the makefile builds, which may be due to something in my WSL setup.

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

`resources_kubernetes_daemon_set_v1` : Added `max_surge` argument for to `rolling_update` block. 

References

Related Issue: #2106 Terraform documentation: https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/daemonset#rolling_update

Kubernetes documentation: https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#:~:text=updateStrategy.rollingUpdate.-,maxSurge,-(IntOrString)

Community Note

hashicorp-cla-app[bot] commented 4 weeks ago

CLA assistant check
All committers have signed the CLA.

hashicorp-cla-app[bot] commented 4 weeks ago

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

alexp-openai commented 1 week ago

When can we expect this to be merged/released? Look forward to this feature, as the workaround option of using manifest also does not work and has PR open since February.