search

hashicorp / terraform-provider-mysql

Terraform MySQL provider – This Terraform provider is archived per our provider archiving process: https://terraform.io/docs/internals/archiving.html
https://www.terraform.io/docs/providers/mysql/
Mozilla Public License 2.0
61 stars 189 forks source link

feat: 🎸 enable setting allow cleartext password flag #105

Closed Amri91 closed 5 years ago

Amri91 commented 5 years ago

Fixes #89

davidji99 commented 5 years ago

Thanks for your contribution!

One suggestion - I recommend adding a allow_native_passwords attribute along with your proposed allow_clear_text_passwords attribute. This way, the user can declarative define which setting to use and not let the provider handle the logic automagically via the ! you have here https://github.com/terraform-providers/terraform-provider-mysql/pull/105/files#diff-0f2037ea77997937e774265a8ddc0677R111.

You can set a ConflictsWith on both attributes so neither can be both set to true.

Amri91 commented 5 years ago

@davidji99 thanks for your recommendation, I hope the new changes are acceptable.

davidji99 commented 5 years ago

@davidji99 thanks for your recommendation, I hope the new changes are acceptable.

One little nitpick but looks great.