hashicorp / terraform-provider-mysql

Terraform MySQL provider – This Terraform provider is archived per our provider archiving process: https://terraform.io/docs/internals/archiving.html
https://www.terraform.io/docs/providers/mysql/
Mozilla Public License 2.0
61 stars 189 forks source link

Fix grant error related to mysql syntax error #57

Closed cgreatbanks closed 5 years ago

cgreatbanks commented 6 years ago

What does this PR change?

Details

Testing

make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v  -timeout 120m
?       github.com/terraform-providers/terraform-provider-mysql [no test files]
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccDatabase
--- PASS: TestAccDatabase (0.05s)
=== RUN   TestAccDatabase_collationChange
--- PASS: TestAccDatabase_collationChange (0.11s)
=== RUN   TestAccGrant
--- PASS: TestAccGrant (0.20s)
=== RUN   TestAccGrant_role
--- SKIP: TestAccGrant_role (0.01s)
    resource_grant_test.go:68: Roles require MySQL 8+
=== RUN   TestAccGrant_roleToUser
--- SKIP: TestAccGrant_roleToUser (0.01s)
    resource_grant_test.go:103: Roles require MySQL 8+
=== RUN   TestAccRole_basic
--- SKIP: TestAccRole_basic (0.01s)
    resource_role_test.go:32: Roles require MySQL 8+
=== RUN   TestAccUserPassword_basic
--- PASS: TestAccUserPassword_basic (0.78s)
=== RUN   TestAccUser_basic
--- PASS: TestAccUser_basic (0.22s)
=== RUN   TestAccUser_auth
--- PASS: TestAccUser_auth (0.13s)
=== RUN   TestAccUser_deprecated
--- PASS: TestAccUser_deprecated (0.35s)
PASS
ok      github.com/terraform-providers/terraform-provider-mysql/mysql   (cached)
RTodorov commented 5 years ago

Can we merge this one? @mrkz55

snjiaojiao commented 5 years ago

when this will be merged?

lasektom commented 5 years ago

Sorry to repeat the same question but any plan to merge it soon? We're affected by it.

davidji99 commented 5 years ago

@lasektom Sorry for the delay. Let me merge this.

lasektom commented 5 years ago

@davidji99 Awesome, thanks!