search

hashicorp / terraform-provider-mysql

Terraform MySQL provider – This Terraform provider is archived per our provider archiving process: https://terraform.io/docs/internals/archiving.html
https://www.terraform.io/docs/providers/mysql/
Mozilla Public License 2.0
61 stars 189 forks source link

Consider replacing satori/go.uuid #69

Closed davidji99 closed 5 years ago

davidji99 commented 5 years ago

Resolves #68

davidji99 commented 5 years ago

Hey @radeksimko,

Not sure if you were planning to start the PR, but I went ahead and opened this PR per issue #68. Could you review?

davidji99 commented 5 years ago

Done @radeksimko

davidji99 commented 5 years ago

Hmm maybe I'm running it wrong @radeksimko? See below:

➜  terraform-provider-mysql git:(issues/68-consider-replacing-satorigouuid) GO111MODULE=on go mod tidy
go: downloading github.com/mitchellh/mapstructure v1.1.2
go: downloading google.golang.org/grpc v1.14.0
go: downloading github.com/hashicorp/vault v0.11.3
go: downloading github.com/golang/protobuf v1.2.0
go: downloading github.com/hashicorp/go-getter v0.0.0-20180809191950-4bda8fa99001
go: downloading golang.org/x/sys v0.0.0-20180823144017-11551d06cbcc
go: downloading github.com/hashicorp/yamux v0.0.0-20180604194846-3520598351bb
go: downloading golang.org/x/text v0.3.0
go: verifying github.com/hashicorp/go-getter@v0.0.0-20180809191950-4bda8fa99001: checksum mismatch
    downloaded: h1:MFPzqpPED05pFyGjNPJEC2sXM6EHTzFyvX+0s0JoZ48=
    go.sum:     h1:qC+3MHkvfCXb1cA9YDpWZ7np8tPOXZceLrW+xyqOgmk=
➜  terraform-provider-mysql git:(issues/68-consider-replacing-satorigouuid) git st
On branch issues/68-consider-replacing-satorigouuid
Your branch is up to date with 'origin/issues/68-consider-replacing-satorigouuid'.

nothing to commit, working tree clean
radeksimko commented 5 years ago

Is it possible that you either run old version of Go (<1.11.4), which has a known bug with checksum calculation (that is why I pinned it to 1.11.5 earlier)? The checksum mismatch would suggest that.

Also even after the upgrade you may have corrupted module cache which may cause certain go commands to misbehave in certain ways.

Can you try running this in a clean environment, such as clean Docker container?

docker run --rm -ti -e GO111MODULE=on -v "$PWD":/_go -w /_go golang:1.11.5 bash
davidji99 commented 5 years ago

Hmmm what diff do you get @radeksimko? I tried what you suggested and the command go mod tidy deleted everything in go.mod and go.sum. And yes, I am running go version 1.11.5.

diff --git a/go.mod b/go.mod
index 83df95b..4e4bf83 100644
--- a/go.mod
+++ b/go.mod
@@ -1,36 +1 @@
 module github.com/terraform-providers/terraform-provider-mysql
-
-require (
-       github.com/apparentlymart/go-cidr v1.0.0 // indirect
-       github.com/aws/aws-sdk-go v1.15.59 // indirect
-       github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d // indirect
-       github.com/blang/semver v3.5.1+incompatible // indirect
-       github.com/go-sql-driver/mysql v1.4.0
-       github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b // indirect
-       github.com/golang/snappy v0.0.0-20180518054509-2e65f85255db // indirect
-       github.com/hashicorp/go-cleanhttp v0.5.0 // indirect
-       github.com/hashicorp/go-getter v0.0.0-20180809191950-4bda8fa99001 // indirect
-       github.com/hashicorp/go-hclog v0.0.0-20181001195459-61d530d6c27f // indirect
-       github.com/hashicorp/go-plugin v0.0.0-20181004024435-314501b665e0 // indirect
-       github.com/hashicorp/go-safetemp v1.0.0 // indirect
-       github.com/hashicorp/go-uuid v1.0.0 // indirect
-       github.com/hashicorp/go-version v1.0.0
-       github.com/hashicorp/hcl v1.0.0 // indirect
-       github.com/hashicorp/hcl2 v0.0.0-20181001210626-3e4b7e0eb20e // indirect
-       github.com/hashicorp/hil v0.0.0-20170627220502-fa9f258a9250 // indirect
-       github.com/hashicorp/logutils v1.0.0 // indirect
-       github.com/hashicorp/terraform v0.11.9
-       github.com/hashicorp/vault v0.11.3 // indirect
-       github.com/keybase/go-crypto v0.0.0-20181017165231-e696c8039bba // indirect
-       github.com/mitchellh/cli v1.0.0 // indirect
-       github.com/mitchellh/copystructure v1.0.0 // indirect
-       github.com/mitchellh/go-homedir v1.0.0 // indirect
-       github.com/mitchellh/hashstructure v1.0.0 // indirect
-       github.com/mitchellh/mapstructure v1.1.2 // indirect
-       github.com/pierrec/lz4 v2.0.5+incompatible // indirect
-       github.com/satori/go.uuid v1.2.0
-       github.com/ulikunitz/xz v0.5.4 // indirect
-       github.com/zclconf/go-cty v0.0.0-20181017232614-01c5aba823a6 // indirect
-       golang.org/x/crypto v0.0.0-20181015023909-0c41d7ab0a0e // indirect
-       golang.org/x/net v0.0.0-20181017193950-04a2e542c03f
-)
diff --git a/go.sum b/go.sum
index 1296f9d..e69de29 100644
--- a/go.sum
+++ b/go.sum
@@ -1,146 +0,0 @@
-github.com/DHowett/go-plist v0.0.0-20180609054337-500bd5b9081b/go.mod h1:5paT5ZDrOm8eAJPem2Bd+q3FTi3Gxm/U4tb2tH8YIUQ=
-github.com/agext/levenshtein v1.2.1 h1:QmvMAjj2aEICytGiWzmxoE0x2KZvE0fvmqMOfy2tjT8=
-github.com/agext/levenshtein v1.2.1/go.mod h1:JEDfjyjHDjOF/1e4FlBE/PkbqA9OfWu2ki2W0IB5558=
-github.com/apparentlymart/go-cidr v1.0.0 h1:lGDvXx8Lv9QHjrAVP7jyzleG4F9+FkRhJcEsDFxeb8w=
-github.com/apparentlymart/go-cidr v1.0.0/go.mod h1:EBcsNrHc3zQeuaeCeCtQruQm+n9/YjEn/vI25Lg7Gwc=
-github.com/apparentlymart/go-dump v0.0.0-20180507223929-23540a00eaa3 h1:ZSTrOEhiM5J5RFxEaFvMZVEAM1KvT1YzbEOwB2EAGjA=
-github.com/apparentlymart/go-dump v0.0.0-20180507223929-23540a00eaa3/go.mod h1:oL81AME2rN47vu18xqj1S1jPIPuN7afo62yKTNn3XMM=
-github.com/apparentlymart/go-textseg v1.0.0 h1:rRmlIsPEEhUTIKQb7T++Nz/A5Q6C9IuX2wFoYVvnCs0=
-github.com/apparentlymart/go-textseg v1.0.0/go.mod h1:z96Txxhf3xSFMPmb5X/1W05FF/Nj9VFpLOpjS5yuumk=
-github.com/armon/go-radix v0.0.0-20180808171621-7fddfc383310 h1:BUAU3CGlLvorLI26FmByPp2eC2qla6E1Tw+scpcg/to=
-github.com/armon/go-radix v0.0.0-20180808171621-7fddfc383310/go.mod h1:ufUuZ+zHj4x4TnLV4JWEpy2hxWSpsRywHrMgIH9cCH8=
-github.com/aws/aws-sdk-go v1.15.59 h1:K/Jy1OfHttpKHHQEy1V0713bb6XMRiA1HO1aAi/sMNg=
-github.com/aws/aws-sdk-go v1.15.59/go.mod h1:E3/ieXAlvM0XWO57iftYVDLLvQ824smPP3ATZkfNZeM=
-github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d h1:xDfNPAt8lFiC1UJrqV3uuy861HCTo708pDMbjHHdCas=
-github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d/go.mod h1:6QX/PXZ00z/TKoufEY6K/a0k6AhaJrQKdFe6OfVXsa4=
-github.com/bgentry/speakeasy v0.1.0 h1:ByYyxL9InA1OWqxJqqp2A5pYHUrCiAL6K3J+LKSsQkY=
-github.com/bgentry/speakeasy v0.1.0/go.mod h1:+zsyZBPWlz7T6j88CTgSN5bM796AkVf0kBD4zp0CCIs=
-github.com/blang/semver v3.5.1+incompatible h1:cQNTCjp13qL8KC3Nbxr/y2Bqb63oX6wdnnjpJbkM4JQ=
-github.com/blang/semver v3.5.1+incompatible/go.mod h1:kRBLl5iJ+tD4TcOOxsy/0fnwebNt5EWlYSAyrTnjyyk=
-github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
-github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
-github.com/fatih/color v1.7.0 h1:DkWD4oS2D8LGGgTQ6IvwJJXSL5Vp2ffcQg58nFV38Ys=
-github.com/fatih/color v1.7.0/go.mod h1:Zm6kSWBoL9eyXnKyktHP6abPY2pDugNf5KwzbycvMj4=
-github.com/go-sql-driver/mysql v1.4.0 h1:7LxgVwFb2hIQtMm87NdgAVfXjnt4OePseqT1tKx+opk=
-github.com/go-sql-driver/mysql v1.4.0/go.mod h1:zAC/RDZ24gD3HViQzih4MyKcchzm+sOG5ZlKdlhCg5w=
-github.com/go-test/deep v1.0.1 h1:UQhStjbkDClarlmv0am7OXXO4/GaPdCGiUiMTvi28sg=
-github.com/go-test/deep v1.0.1/go.mod h1:wGDj63lr65AM2AQyKZd/NYHGb0R+1RLqB8NKt3aSFNA=
-github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b h1:VKtxabqXZkF25pY9ekfRL6a582T4P37/31XEstQ5p58=
-github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b/go.mod h1:SBH7ygxi8pfUlaOkMMuAQtPIUF8ecWP5IEl/CR7VP2Q=
-github.com/golang/protobuf v1.1.0/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U=
-github.com/golang/protobuf v1.2.0 h1:P3YflyNX/ehuJFLhxviNdFxQPkGK5cDcApsge1SqnvM=
davidji99 commented 5 years ago

Hey @radeksimko,

See my comment above. Am I missing something else here?

davidji99 commented 5 years ago

@radeksimko I think I nailed this one down. Please review.