feature request: add support for FixedInstanceSize

hashicorp / terraform-provider-oneandone

Terraform 1&1 provider. Please note: This Terraform provider is archived per our provider archiving process: https://terraform.io/docs/internals/archiving.html

https://www.terraform.io/docs/providers/oneandone/

Mozilla Public License 2.0

5 stars 11 forks source link

feature request: add support for FixedInstanceSize #4

Closed ekle closed 7 years ago

ekle commented 7 years ago

I started to add it myself (https://github.com/alfatraining/terraform-provider-oneandone), but there are many edge cases, i don't know how to handle, like:

it is not possible to shrink FixedInstances
it is not possible to increase memory from less than 4GB to 4GB without stopping the server

FixedInstances costs around the half than flexible servers. in most cases its cheaper to use a faster model of them, than using a individual sized server.

jasmingacic commented 7 years ago

@ekle Currently server resource has ram, cores_per_processor, vcores and image as required fields. If FixedInstances are added we'd need to do those checks. Also when it comes to update, like you said many edge cases would arise. But definitely it would be a good idea to add support for it. But if you already have done some work please submit your PR and we can work on it together.

jasmingacic commented 7 years ago

About increasing the memory there is a slight problem. When server is shut down and hardware update is performed (increasing RAM) we are not able to track server state since it is already POWERED_OFF. So we would not know how long to wait until the change is accepted and the server is ready to be POWERED_ON.

ekle commented 7 years ago

@jasminSPC here: https://github.com/terraform-providers/terraform-provider-oneandone/pull/5 it is based on your fork at the moment.

jasmingacic commented 7 years ago

@ekle thanks I'm looking at it.

jasmingacic commented 7 years ago

Fixed with #5