New attributes into environments

[marek130]

Add attribute webhooks and emails into environments

[ewilde]

@marek130 thank you for raising this PR. Looks great!

Couple of things to take a look at:

• [ ] can you run go imports against your changes? make goimports this makes sure go code is formatted
• [ ] can you update the integrations tests to include the new attributes you've added and copy the output of the test run in the PR text, happy to help if you need anything

[marek130]

@ewilde Hi, i have a problem with normal version of terraform-provider-runscope.

The problem is that order of test steps is not guaranteed. In which order will tests steps be applied into runscope?

For example if i have:

resource "runscope_step" "step0_Address_search_NOMINATIM" {
    bucket_id      = "${var.bucket_id}"
    test_id           = "${runscope_test.Address_search_NOMINATIM.id}"
    step_type      = "request"
    url                 = "https://example.com"
    method         = "GET"
}

resource "runscope_step" "step1_Address_search_NOMINATIM" {
    bucket_id   = "${var.bucket_id}"
    test_id        = "${runscope_test.Address_search_NOMINATIM.id}"
    step_type   = "request"
    url              = "https://example.com"
    method      = "GET"

}

the result wiill be STEP1 and then STEP0. Thanks !

[ewilde]

@marek130 I think you can solve this problem by using the depends_on attribute see: https://www.terraform.io/intro/getting-started/dependencies.html#implicit-and-explicit-dependencies

Have you been able to update the integration tests for these new attributes?

[marek130]

@ewilde Yes, I have. The output of the test run:

go lint .
open github.com/terraform-providers/terraform-provider-runscope: no such file or directory
open github.com/terraform-providers/terraform-provider-runscope/runscope: no such file or directory
==> Checking that code complies with goimports requirements...
go vet .
Build succeeded
go test -v . ./runscope
?       github.com/terraform-providers/terraform-provider-runscope  [no test files]
=== RUN   TestAccDataSourceRunscopeBucket
--- PASS: TestAccDataSourceRunscopeBucket (5.88s)
=== RUN   TestAccDataSourceRunscopeBuckets
--- PASS: TestAccDataSourceRunscopeBuckets (4.92s)
=== RUN   TestAccDataSourceRunscopeIntegration_Basic
--- PASS: TestAccDataSourceRunscopeIntegration_Basic (2.11s)
=== RUN   TestAccDataSourceRunscopeIntegration_Filter
--- PASS: TestAccDataSourceRunscopeIntegration_Filter (2.06s)
=== RUN   TestAccDataSourceRunscopeIntegrations_Basic
--- PASS: TestAccDataSourceRunscopeIntegrations_Basic (2.39s)
=== RUN   TestAccDataSourceRunscopeIntegrations_usage
--- PASS: TestAccDataSourceRunscopeIntegrations_usage (8.32s)
=== RUN   TestAccImportRunscopeBucket
--- PASS: TestAccImportRunscopeBucket (4.23s)
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProviderImpl
--- PASS: TestProviderImpl (0.00s)
=== RUN   TestAccBucket_basic
--- PASS: TestAccBucket_basic (3.82s)
=== RUN   TestAccEnvironment_basic
--- PASS: TestAccEnvironment_basic (8.54s)
=== RUN   TestAccEnvironment_do_not_verify_ssl
--- PASS: TestAccEnvironment_do_not_verify_ssl (9.56s)
=== RUN   TestAccSchedule_basic
--- PASS: TestAccSchedule_basic (11.05s)
=== RUN   TestAccStep_basic
--- PASS: TestAccStep_basic (10.67s)
=== RUN   TestAccStep_multiple_steps
--- PASS: TestAccStep_multiple_steps (11.76s)
=== RUN   TestAccTest_basic
--- PASS: TestAccTest_basic (7.12s)
=== RUN   TestExpandStringList
--- PASS: TestExpandStringList (0.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-runscope/runscope 92.436s
go test -count=1 -v ./runscope -run="TestAcc" -timeout 20m -sweep "eu-west-1"
=== RUN   TestAccDataSourceRunscopeBucket
--- PASS: TestAccDataSourceRunscopeBucket (5.39s)
=== RUN   TestAccDataSourceRunscopeBuckets
--- PASS: TestAccDataSourceRunscopeBuckets (5.16s)
=== RUN   TestAccDataSourceRunscopeIntegration_Basic
--- PASS: TestAccDataSourceRunscopeIntegration_Basic (2.04s)
=== RUN   TestAccDataSourceRunscopeIntegration_Filter
--- PASS: TestAccDataSourceRunscopeIntegration_Filter (2.11s)
=== RUN   TestAccDataSourceRunscopeIntegrations_Basic
--- PASS: TestAccDataSourceRunscopeIntegrations_Basic (2.48s)
=== RUN   TestAccDataSourceRunscopeIntegrations_usage
--- PASS: TestAccDataSourceRunscopeIntegrations_usage (7.88s)
=== RUN   TestAccImportRunscopeBucket
--- PASS: TestAccImportRunscopeBucket (4.12s)
=== RUN   TestAccBucket_basic
--- PASS: TestAccBucket_basic (3.90s)
=== RUN   TestAccEnvironment_basic
--- PASS: TestAccEnvironment_basic (9.29s)
=== RUN   TestAccEnvironment_do_not_verify_ssl
--- PASS: TestAccEnvironment_do_not_verify_ssl (14.33s)
=== RUN   TestAccSchedule_basic
--- PASS: TestAccSchedule_basic (9.85s)
=== RUN   TestAccStep_basic
--- PASS: TestAccStep_basic (10.33s)
=== RUN   TestAccStep_multiple_steps
--- PASS: TestAccStep_multiple_steps (13.81s)
=== RUN   TestAccTest_basic
--- PASS: TestAccTest_basic (11.54s)
PASS
ok      github.com/terraform-providers/terraform-provider-runscope/runscope 102.247s

[ewilde]

@marek130 thanks for this PR 👍 , I will merge and change to a list

[ewilde]

@marek130 this is now released