Breaking change in substitution in v2.0.0

hashicorp / terraform-provider-template

Terraform template provider

https://www.terraform.io/docs/providers/template/

Mozilla Public License 2.0

130 stars 89 forks source link

Breaking change in substitution in v2.0.0 #52

Closed krk closed 5 years ago

krk commented 5 years ago

In v1.0.0, $$(a) is replaced to $(a) whereas v2.0.0 keeps the original.

To test, add the following test cases to https://github.com/terraform-providers/terraform-provider-template/blob/05c8f40512b96b2009f0ad4369f3634b3cddbb6f/template/datasource_template_file_test.go#L17

{`{a="foo"}`, `$$(a)`, `$$(a)`},
{`{a="foo"}`, `$(a)`, `$(a)`},

It passes in v2.0.0 but fails in v1.0.0

apparentlymart commented 5 years ago

Hi @krk,

This seems to be the same as #49, so I'm going to close this just to consolidate the discussion. Please see the comments there to either constrain your provider version to the 1.0 release or to remove this redundant escaping.