search

hashicorp / terraform-provider-terraform

Terraform terraform provider
https://www.terraform.io/docs/providers/terraform/
Mozilla Public License 2.0
24 stars 22 forks source link

Upgrading to Terraform 0.10.8 #18

Closed tombuildsstuff closed 7 years ago

tombuildsstuff commented 7 years ago

Turns out master's still pointing to Terraform 0.10.0

$ govendor fetch github.com/hashicorp/terraform/...@v0.10.8

in order to fix the build - I then compared this branch's version and ran:

$ govendor fetch github.com/hashicorp/consul/api@610f3c86a089817b5bd5729a3b8c2db33a9ae2b0
$ govendor fetch github.com/hashicorp/go-getter@a686900cb3753aa644dc4812be91ceaf9fdd3b98
$ govendor fetch github.com/coreos/etcd/clientv3@v3.2.7
govendor fetch github.com/hashicorp/go-plugin@a5174f84d7f8ff00fb07ab4ef1f380d32eee0e63

This should finally fix https://github.com/terraform-providers/terraform-provider-azurerm/issues/351

phamann commented 7 years ago

@tombuildsstuff @apparentlymart It seems that this PR and the corresponding 1.0.2 release has broken clients still using Terraform 0.10.0 as this plugin as a provider. I get the following error:

provider.terraform: dial unix /var/folders/gm/g6yqvzvx1tg6890p349w52xm0000gn/T/plugin648040195|netrpc: connect: no such file or directory

Upgrading my local Terraform to 0.10.8 solved the problem.

apparentlymart commented 7 years ago

Hmm... thanks for reporting that, @phamann.

That certainly wasn't intended :confounded: ... I think this is due to a change to the underlying plugin library we use which now supports several different plugin protocols, but seems to be confusing old versions of Terraform by including the protocol announcement (|netrpc) in its startup message.

Unfortunately I don't think there's much we can do here since we can't re-issue the old 0.10 releases to have the new client... we'll watch out for this as we upgrade the go-plugin version used by other providers.

Sorry for the unexpected breakage!