hashicorp / terraform-provider-time

Utility provider that provides Time-Based Resources
https://registry.terraform.io/providers/hashicorp/time/latest
Mozilla Public License 2.0
104 stars 30 forks source link

Use terraform-plugin-framework-timetypes for RFC3339 string attributes #230

Closed bflad closed 1 year ago

bflad commented 1 year ago

Community Note

Reference: https://pkg.go.dev/github.com/hashicorp/terraform-plugin-framework-timetypes/timetypes

Will submit a feature request upstream for time.Time to/from implementations to remove more of the boilerplate string <-> time.Time conversions and error handling.

bflad commented 1 year ago

should we add a changelog entry for this PR? Switching to this type internally introduces semantic equality logic that wasn't previously here

Since there's no backing API for these resources that could potentially change the formatting of the value, I'm not sure if there's a way for the semantic equality logic to have any effect in that sense.

github-actions[bot] commented 5 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.