resource/time_offset: Correctly calculate offset when multiple offsets are set

hashicorp / terraform-provider-time

Utility provider that provides Time-Based Resources

https://registry.terraform.io/providers/hashicorp/time/latest

Mozilla Public License 2.0

103 stars 31 forks source link

resource/time_offset: Correctly calculate offset when multiple offsets are set #248

Closed pascal-hofmann closed 9 months ago

pascal-hofmann commented 11 months ago

Contradicting the docs, currently the time_offset resource does not support setting multiple different offsets (e.g. "3 days and 5 hours" or similar).

This PR fixes the resource and adds a test that ensures the behavior does not break in the futures.

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

pascal-hofmann commented 11 months ago

I just saw #189 which implements the same. My test case covers more cases, but I did not update the documentation.

I wonder why this bug is not fixed in the first place. Why not just release a new major version with this?

SBGoods commented 9 months ago

Closing this PR as the fix was superseded by #189 and released in v0.10.0

github-actions[bot] commented 3 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.