Add support for HMAC type to vault_transit_secret_backend_key

roberteckert commented 1 year ago

Add key_size as it is necessary for HMAC. Default to 0 bits as that is the default for all key types except HMAC currently.

Description

This PR updates the vault_transit_secret_backend_key to accept the hmac key type along with the requisite key_size argument so that transit keys of the hmac type can be created.

Relates OR Closes #0000

Checklist

[x] Added CHANGELOG entry (only for user-facing changes)
[x] Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

hashicorp-cla commented 1 year ago

All committers have signed the CLA.

roberteckert commented 1 year ago

Thanks for the feedback. I:

Removed ValidateFunc to rely on Vault's internal validation
Updated CHANGELOG.md
Slightly tweaked the description of key_size
Wrapped the data["key_size"] allocation in a check for Vault version
Added SkipFunc blocks to the hmac tests

roberteckert commented 1 year ago

This seems done - is there anything else you require from me?

fairclothjm commented 1 year ago

We don't require anything else, thanks @roberteckert!

hashicorp / terraform-provider-vault