Add support for Oracle database plugin connection options

dheeg commented 10 months ago

Description

In 2021 the Oracle database plugin for Vault introduced new configuration options as described here: https://github.com/hashicorp/vault-plugin-database-oracle/pull/62

This PR exposes those database connection options, which are especially important for Oracle AWS RDS installations, as those don't support the default plugin revocation statements see: https://github.com/hashicorp/vault-plugin-database-oracle/issues/45

I personally don't expect that this PR will receive a lot of upvotes, because it's a niche scenario => Oracle on AWS + Vault + Terraform to provision Vault. However it might be important for a few enterprises (including us).

Checklist

[x] Added CHANGELOG entry (only for user-facing changes)
[x] Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

hashicorp-cla commented 10 months ago

All committers have signed the CLA.

dheeg commented 9 months ago

@fairclothjm Sorry for pinging directly. Is there a chance to get a review for this PR?

ram-parameswaran commented 7 months ago

@dheeg Hello, thanks for the contribution! Sorry for the delay. Could you rebase your changes on the main branch? Thanks!

Completed on behalf of user @dheeg

hashicorp / terraform-provider-vault