Add iam_tags to vault_aws_secret_backend_role resource

[pporee]

Description

Fix https://github.com/hashicorp/terraform-provider-vault/issues/1073

Relates OR Closes #0000

Checklist

• [ ] Added CHANGELOG entry (only for user-facing changes)
• [ ] Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

[hashicorp-cla]

All committers have signed the CLA.

[Shocktrooper]

Hello! I am interested in this because it will allow us to use AWS policy variables in our IAM policies. Without this we cannot do that and thus cannot use AWS Policy variables based off of tags

• https://docs.aws.amazon.com/IAM/latest/UserGuide/access_tags.html

[Shocktrooper]

@thyton Can you check this code again and see if there are any other changes needed other than what you have reviewed since its a few months old now. if @pporee cannot complete this I can go ahead and try to finish it with a new MR

[thyton]

@Shocktrooper Thank you for your patience! I've created a WIP #2231 to finish the remaining work and close this PR. I'm expecting to close #2231 within 2 weeks.

[Shocktrooper]

Thank you for picking this up! @thyton Let me know if there is anything I can do

[thyton]

@pporee @Shocktrooper This feature will be out in release 4.3.0. Thank you again for your patience!