Closed fairclothjm closed 9 months ago
@austingebauer Thanks for the review!
clean way to define the schema attributes of the various auth login methods in a single location instead of having them duplicated for both sdkv2/fw providers
I think we could do that if we wrote a wrapper to convert to either sdkv2 or Framework but I am not convinced that it would be worth it. I do think the change frequency is pretty low. I am happy to discuss more if you like.
Also, I am working on adding tests to assert the multiplexing schemas match. terraform apply
will fail if the schemas don't match but of course we want to catch it before then. :)
@fairclothjm - Thanks! I'm good with having the fields defined in both places provided the test can make developers aware of diffs. If it becomes a pain, we can write that conversion code at a later date 👍
Description
Complete the provider configuration setup for the auth login methods.
This PR
Phase 2
internal/provider/auth.go
file to handle defaults and required fields since those can no longer be set on the Provider SchemasetDefaultFields
methodPrevious Phases
Phase 0
Phase 1
Subsequent Phases
Phase 3