Closed ram-parameswaran closed 7 months ago
Thanks for the contribution @ram-parameswaran ! Are there any tests we could add to verify this behavior?
@fairclothjm I have added acceptance test results back into the PR description. Let me know if anything further is needed. Thanks!
Hi @ram-parameswaran, thanks for adding the output from the Vault CLI. We would also like to validate that the tests within the Terraform Vault Provider pass with these updates. Could we also add an additional test step for MySQL Aurora to TestAccDatabaseSecretBackendConnection_mysql_tls
on this line in the test file to confirm that the fields tls_ca
and tls_certificate_key
can be set to the resource via these configs? I think adding just the one test step for Aurora should suffice for RDS and Legacy as well, since the changes are the same. You will need a config function for the new test step, and we can add a testAccDatabaseSecretBackendConnectionConfig_mysql_aurora_tls
function that is basically the same as the MySQL TLS config function in the same file.
Please let us know if you have any questions, and thanks once again for contributing the to Terraform Vault Provider!
@vinay-gopalan thanks for your valuable comments. I have added the requested tests. Please review and let me know if you would like to me to change anything.
Description
Initially raised by(on behalf of) ent customer via Zendesk in an enterprise support engagement.
allow mysql_rds,mysql_aurora,mysql_legacy options of vault_database_secret_backend_connection terraform resource to allow specifying tls_ca and tls_certificate_key
Checklist
Output from acceptance testing:
Community Note