Update max db conn

[conor-mccullough]

Description

The default value in our docs is 4, I'm not sure if there is a good reason to keep the providers default as 2. In my mind it makes sense to keep the same limit across different implementation techniques, unless there's a justification for this being lower in the provider.

Checklist

• [ X] Added CHANGELOG entry (only for user-facing changes)
• [ ] Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

ok      github.com/hashicorp/terraform-provider-vault/vault 1.862s

• Full output is attached to VAULT-22953, cut it here as it was pretty long.

This is a pretty basic change so I haven't done super extensive testing. Let me know if this needs more stringent tests performed, happy to resubmit.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

[fairclothjm]

@conor-mccullough Thanks for the submission! It looks like a few tests are failing due to the previously expected default value

TestAccDatabaseSecretBackendConnection_postgresql_import
TestAccDatabaseSecretBackendConnection_mssql
TestAccDatabaseSecretBackendConnection_mysql
TestAccDatabaseSecretBackendConnectionUpdate_mysql
TestAccDatabaseSecretBackendConnection_postgresql
TestAccDatabaseSecretsMount_mssql

[conor-mccullough]

Hi @fairclothjm

Apologies for the delay here. I was in the process of testing this, and had also implemented your additional feedback from Slack in the new change:

I am wondering if we should instead make this a computed value so that we don’t have to update the TFVP code if the Default ever changes in Vault?

However due to its low priority/impact relative to some more-than-usual firefighting over the last month, it keeps getting pushed to the bottom of my list. I hope to get to it in the next month assuming things calm a bit more.