feat(pki): Add support for ACME configuration

Viper61 commented 4 months ago

Description

This PR adds a new resource to enable ACME configuration of a PKI (vault_pki_secret_backend_config_acme).

Relates #1947

Checklist

[x] Added CHANGELOG entry (only for user-facing changes)
[x] Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

Vault 1.13

``` $ VAULT_ADDR=http://172.20.0.1:8213 TESTARGS="--run TestPkiSecretBackendConfigACME_basic" make testacc ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test --run TestPkiSecretBackendConfigACME_basic -timeout 30m ./... ? github.com/hashicorp/terraform-provider-vault [no test files] ? github.com/hashicorp/terraform-provider-vault/cmd/coverage [no test files] ? github.com/hashicorp/terraform-provider-vault/cmd/generate [no test files] ? github.com/hashicorp/terraform-provider-vault/helper [no test files] ? github.com/hashicorp/terraform-provider-vault/internal/consts [no test files] ok github.com/hashicorp/terraform-provider-vault/codegen 0.010s [no tests to run] ? github.com/hashicorp/terraform-provider-vault/internal/identity/group [no test files] ? github.com/hashicorp/terraform-provider-vault/internal/identity/mfa [no test files] ? github.com/hashicorp/terraform-provider-vault/internal/pki [no test files] ok github.com/hashicorp/terraform-provider-vault/internal/identity/entity 0.032s [no tests to run] ? github.com/hashicorp/terraform-provider-vault/internal/sync [no test files] ? github.com/hashicorp/terraform-provider-vault/schema [no test files] ok github.com/hashicorp/terraform-provider-vault/internal/provider 0.040s [no tests to run] ok github.com/hashicorp/terraform-provider-vault/testutil 0.006s [no tests to run] ok github.com/hashicorp/terraform-provider-vault/util 0.007s [no tests to run] ok github.com/hashicorp/terraform-provider-vault/vault 0.026s ```

Vault 1.14.0

``` $ VAULT_ADDR=http://172.20.0.1:8214 TESTARGS="--run TestPkiSecretBackendConfigACME_basic" make testacc ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test --run TestPkiSecretBackendConfigACME_basic -timeout 30m ./... ? github.com/hashicorp/terraform-provider-vault [no test files] ? github.com/hashicorp/terraform-provider-vault/cmd/coverage [no test files] ? github.com/hashicorp/terraform-provider-vault/cmd/generate [no test files] ? github.com/hashicorp/terraform-provider-vault/helper [no test files] ? github.com/hashicorp/terraform-provider-vault/internal/consts [no test files] ok github.com/hashicorp/terraform-provider-vault/codegen 0.011s [no tests to run] ? github.com/hashicorp/terraform-provider-vault/internal/identity/group [no test files] ? github.com/hashicorp/terraform-provider-vault/internal/identity/mfa [no test files] ? github.com/hashicorp/terraform-provider-vault/internal/pki [no test files] ok github.com/hashicorp/terraform-provider-vault/internal/identity/entity 0.025s [no tests to run] ? github.com/hashicorp/terraform-provider-vault/internal/sync [no test files] ? github.com/hashicorp/terraform-provider-vault/schema [no test files] ok github.com/hashicorp/terraform-provider-vault/internal/provider 0.028s [no tests to run] ok github.com/hashicorp/terraform-provider-vault/testutil 0.012s [no tests to run] ok github.com/hashicorp/terraform-provider-vault/util 0.005s [no tests to run] ok github.com/hashicorp/terraform-provider-vault/vault 3.727s ```

Vault 1.14

``` $ VAULT_ADDR=http://172.20.0.1:8314 TESTARGS="--run TestPkiSecretBackendConfigACME_basic" make testacc ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test --run TestPkiSecretBackendConfigACME_basic -timeout 30m ./... ? github.com/hashicorp/terraform-provider-vault [no test files] ? github.com/hashicorp/terraform-provider-vault/cmd/coverage [no test files] ? github.com/hashicorp/terraform-provider-vault/cmd/generate [no test files] ? github.com/hashicorp/terraform-provider-vault/helper [no test files] ? github.com/hashicorp/terraform-provider-vault/internal/consts [no test files] ok github.com/hashicorp/terraform-provider-vault/codegen 0.006s [no tests to run] ? github.com/hashicorp/terraform-provider-vault/internal/identity/group [no test files] ? github.com/hashicorp/terraform-provider-vault/internal/identity/mfa [no test files] ? github.com/hashicorp/terraform-provider-vault/internal/pki [no test files] ok github.com/hashicorp/terraform-provider-vault/internal/identity/entity 0.049s [no tests to run] ? github.com/hashicorp/terraform-provider-vault/internal/sync [no test files] ? github.com/hashicorp/terraform-provider-vault/schema [no test files] ok github.com/hashicorp/terraform-provider-vault/internal/provider 0.030s [no tests to run] ok github.com/hashicorp/terraform-provider-vault/testutil 0.006s [no tests to run] ok github.com/hashicorp/terraform-provider-vault/util 0.004s [no tests to run] ok github.com/hashicorp/terraform-provider-vault/vault 3.848s ```

Vault 1.15

``` $ VAULT_ADDR=http://172.20.0.1:8215 TESTARGS="--run TestPkiSecretBackendConfigACME_basic" make testacc ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test --run TestPkiSecretBackendConfigACME_basic -timeout 30m ./... ? github.com/hashicorp/terraform-provider-vault [no test files] ? github.com/hashicorp/terraform-provider-vault/cmd/coverage [no test files] ? github.com/hashicorp/terraform-provider-vault/cmd/generate [no test files] ? github.com/hashicorp/terraform-provider-vault/helper [no test files] ? github.com/hashicorp/terraform-provider-vault/internal/consts [no test files] ok github.com/hashicorp/terraform-provider-vault/codegen 0.007s [no tests to run] ? github.com/hashicorp/terraform-provider-vault/internal/identity/group [no test files] ? github.com/hashicorp/terraform-provider-vault/internal/identity/mfa [no test files] ? github.com/hashicorp/terraform-provider-vault/internal/pki [no test files] ? github.com/hashicorp/terraform-provider-vault/internal/sync [no test files] ? github.com/hashicorp/terraform-provider-vault/schema [no test files] ok github.com/hashicorp/terraform-provider-vault/internal/identity/entity 0.048s [no tests to run] ok github.com/hashicorp/terraform-provider-vault/internal/provider 0.055s [no tests to run] ok github.com/hashicorp/terraform-provider-vault/testutil 0.007s [no tests to run] ok github.com/hashicorp/terraform-provider-vault/util 0.005s [no tests to run] ok github.com/hashicorp/terraform-provider-vault/vault 3.807s ```

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

igor-nikiforov commented 2 months ago

@fairclothjm Could you please review this PR? Thanks!

igor-nikiforov commented 6 days ago

@benashz friendly reminder.

hashicorp / terraform-provider-vault