search

hashicorp / terraform-provider-vault

Terraform Vault provider
https://www.terraform.io/docs/providers/vault/
Mozilla Public License 2.0
451 stars 535 forks source link

fix build vault api version #2175

Closed fairclothjm closed 4 months ago

benashz commented 4 months ago

@fairclothjm It looks this broke the build on main. Might be worth taking a look at it.

fairclothjm commented 4 months ago

@benashz We recently added golangci-lint as a build step and that is what is failing. See https://github.com/hashicorp/terraform-provider-vault/actions/runs/8176992328/job/22357626718

I plan to open a PR to fix the outstanding lint errors but it has been low priority recently. Sorry for the noise in the build!

benashz commented 4 months ago

@fairclothjm ok, we may want to disable that check then, since a failing build on main should prevent a release.

fairclothjm commented 4 months ago

@benashz No problem! https://github.com/hashicorp/terraform-provider-vault/pull/2179

benashz commented 4 months ago

Thanks!