hashicorp / terraform-provider-vault

Terraform Vault provider
https://www.terraform.io/docs/providers/vault/
Mozilla Public License 2.0
451 stars 535 forks source link

Fix PKI Issuer overwrites on updates #2186

Closed vinay-gopalan closed 4 months ago

vinay-gopalan commented 4 months ago

Description

Previously, the resource was not employing a JSON Merge Patch when making update requests to the Vault server. This was causing all data to be overwritten for the issuer. This fix follows the Vault documentation and makes a PATCH request to the issuer API when sending update info. Vault docs

Relates OR Closes #1990 #2061

Checklist

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccPKISecretBackendIssuer_basic'
=== RUN   TestAccPKISecretBackendIssuer_basic
    resource_pki_secret_backend_issuer_test.go:29: Vault server version "1.17.0-beta1+ent"
--- PASS: TestAccPKISecretBackendIssuer_basic (3.82s)
PASS