hashicorp / terraform-provider-vault

Terraform Vault provider
https://www.terraform.io/docs/providers/vault/
Mozilla Public License 2.0
451 stars 535 forks source link

Update Sync Association resource to include sync metadata for all subkeys #2202

Closed vinay-gopalan closed 3 months ago

vinay-gopalan commented 3 months ago

Description

Previously, the association resource did not account for the secret-key granularity, which would create a sync target for each subkey of a KV secret. Now, the association resource must keep track of the sync statuses for all subkeys of this associated secret.

Notable improvements/changes:

Checklist

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestSecretsSyncAssociation_gh'
=== RUN   TestSecretsSyncAssociation_gh
    resource_secrets_sync_association_test.go:38: Vault server version "1.16.0+ent"
--- PASS: TestSecretsSyncAssociation_gh (2.67s)
PASS
raymonstah commented 3 months ago

LGTM!