hashicorp / terraform-provider-vault

Terraform Vault provider
https://www.terraform.io/docs/providers/vault/
Mozilla Public License 2.0
451 stars 535 forks source link

[Bug]: vault_kv_secret_v2 fails on imported resource when data_json should be ignored #2205

Closed sielaq closed 3 months ago

sielaq commented 3 months ago

Terraform Core Version

1.7.5

Terraform Vault Provider Version

4.1.0

Vault Server Version

1.15.2

Affected Resource(s)

vault_kv_secret_v2

Expected Behavior

After importing resource applying TF with lifecycle -> ignore_changes -> data_json it should not crash and apply the diff (like changing metadata etc.)

Actual Behavior

Despite of default data_json is set AND lifecycle -> ignore_changes -> data_json is set too, it crash.

Relevant Error/Panic Output Snippet

vault_kv_secret_v2.common["sielaq"]: Modifying... [id=example/data/common/sielaq]
╷
│ Error: data_json "" syntax error: unexpected end of JSON input
│
│   with vault_kv_secret_v2.common["sielaq"],
│   on kv.tf line 1, in resource "vault_kv_secret_v2" "common":
│    1: resource "vault_kv_secret_v2" "common" {
│

Terraform Configuration Files

Steps to Reproduce

Terraform will perform the following actions:

vault_kv_secret_v2.common["sielaq"] will be updated in-place

~ resource "vault_kv_secret_v2" "common" { id = "example/data/common/sielaq" name = "common/sielaq"

(4 unchanged attributes hidden)

  ~ custom_metadata {
      ~ data                 = {
          + "tag" = "created by terraform"
        }
        # (3 unchanged attributes hidden)
    }
}

Plan: 0 to add, 1 to change, 0 to destroy.

vault_kv_secret_v2.common["sielaq"]: Modifying... [id=example/data/common/sielaq] ╷ │ Error: data_json "" syntax error: unexpected end of JSON input │ │ with vault_kv_secret_v2.common["sielaq"], │ on kv.tf line 1, in resource "vault_kv_secret_v2" "common": │ 1: resource "vault_kv_secret_v2" "common" { │ ╵



### Debug Output

_No response_

### Panic Output

_No response_

### Important Factoids

_No response_

### References

_No response_

### Would you like to implement a fix?

No
fairclothjm commented 3 months ago

closed by https://github.com/hashicorp/terraform-provider-vault/pull/2207