search

hashicorp / terraform-provider-vault

Terraform Vault provider
https://www.terraform.io/docs/providers/vault/
Mozilla Public License 2.0
459 stars 540 forks source link

Support missing token parameters on `vault_okta_auth_backend` resource #2210

Closed vinay-gopalan closed 3 months ago

vinay-gopalan commented 6 months ago

Description

Supports missing common token parameters.

Relates OR Closes #1353

Checklist

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccOktaAuthBackend_TokenFields'
=== RUN   TestAccOktaAuthBackend_TokenFields
=== PAUSE TestAccOktaAuthBackend_TokenFields
=== CONT  TestAccOktaAuthBackend_TokenFields
--- PASS: TestAccOktaAuthBackend_TokenFields (1.51s)
PASS
vinay-gopalan commented 3 months ago

This all looks good to me! Great job! 👏 I had one question, just to verify - Were these parameters added later on to Okta? Do we need to guard them with a version check, or are these available in most versions?

Good question! Looks like these fields have existed since before Vault 1.10.x and they just hadn't been included in the resource 😬 So we should be good, thanks for confirming 🙏🏼