search

hashicorp / terraform-provider-vault

Terraform Vault provider
https://www.terraform.io/docs/providers/vault/
Mozilla Public License 2.0
451 stars 535 forks source link

Add missing parameters to `vault_mount` #2235

Closed vinay-gopalan closed 1 month ago

vinay-gopalan commented 2 months ago

Description

Adds parameters to the resource that were missing, including newly 1.16 added fields.

Checklist

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...
vinay-gopalan commented 2 months ago

I had one question about this change, other than that it looks pretty straightforward.

It does look like the tests are not passing e.g: https://github.com/hashicorp/terraform-provider-vault/actions/runs/8994620751/job/24708374987?pr=2235#step:9:1766

Will you also be doing the docs update under this PR?

Good catch! Docs slipped my mind and I will add them in. And yes! The tests failures are expected, looks like the TFVP helped uncover a bug in a newly added Vault 1.16.x field. There is a fix PR up on the Vault repo. For now, I'll add a TODO note to fix that test, and we can update that test once the fix is merged into Vault. Thanks for the thoroughness!