hashicorp / terraform-provider-vsphere

Terraform Provider for VMware vSphere
https://registry.terraform.io/providers/hashicorp/vsphere/
Mozilla Public License 2.0
614 stars 448 forks source link

Set vSAN client with the current version of the service endpoint #1933

Closed zxinyu08 closed 4 months ago

zxinyu08 commented 1 year ago

Community Guidelines

Description

Currently the vSAN client created in provider uses reserved version, we found Unrecognized version URI urn:vsan/reservedpattern in vSAN health log from backend.

2023-06-07T08:45:11.057Z verbose vsanvcmgmtd[50250] [vSAN@6876 sub=VsanSoapSvc opID=Run-Http2ServerSession-34] Unrecognized version URI; using default handler; urn:vsan/, action: urn:vsan/reserved, <{stm: {<io_obj p:0x00007fdd851cc288, h:38, <UNIX '/var/run/vmware-vsan/vsan-sdk-pipe'>, <UNIX ''>>, id: 15, state(in/out): 3/1}, session: <5247cc10-8e1f-9494-2266-98099d305dd2, <UNIX '/var/run/vmware-vsan/vsan-sdk-pipe'>, <UNIX ''>>, req: {POST, /vsanHealth}}, urn:vsan/>

The RC is that when creating vSAN client, the version is not set, but it's a best practice to set it as the current version of the service endpoint. Since whatever version of customer's env, 7.0 or 8.0, the compatibility of each vSAN API should be guaranteed by provider side.

With this enhancement, backend log should be like:

req: <{stm: {<io_obj p:0x00007fdd794578d8, h:36, <UNIX '/var/run/vmware-vsan/vsan-sdk-pipe'>, <UNIX ''>>, id: 1, state(in/out): 3/1}, session: <522ecbb3-fb9c-5bd5-1dd7-68ebea5ba3c8, <UNIX '/var/run/vmware-vsan/vsan-sdk-pipe'>, <UNIX ''>>, req: {POST, /vsanHealth}}, urn:vsan/8.0.0.2>

urn:vsan/8.0.0.2 version should be set successfully.

Use Case(s)

support vSAN configuration of all versions of vSphere env, avoiding any potential issues of incompatibility.

Potential Terraform Provider Configuration

No response

References

No response

github-actions[bot] commented 5 months ago

Marking this issue as stale due to inactivity in the past 180 days. This helps us focus on the active issues. If this issue is reproducible with the latest version of the provider, please comment. If this issue receives no comments in the next 30 days it will automatically be closed. If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

github-actions[bot] commented 3 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.