Open orenr2301 opened 2 weeks ago
Hello, orenr2301! 🖐
Thank you for submitting an issue for this provider. The issue will now enter into the issue lifecycle.
If you want to contribute to this project, please review the contributing guidelines and information on submitting pull requests.
Community Guidelines
Description
For a long time, we waited for the workload management resource so first of all thank you.
Secondly: The doc of the supervisor resource is very light! It just has a simple description of each attribute.
it doesn't show what are the requested types
Cannot know whether an attribute is optional or required
Doesn't show schemas of resource structure
Doesn't show if a block might be repeatable or not
No specific examples, and no description of other stuff
Also since each workload can have more than one namespace configured under it, you should set the namespace to a list object type, so a user can put more than one namespace
You should take into account, that not everyone who is familiar with Tanzu(tkgs), has expertise in vSpehere. Therefore you need to describe as well, if there are crucial dependencies, and there are.
Use Case(s)
I need to assign more namespaces under one workload management cluster, currently, it's not enabled in your code
Potential Terraform Provider Configuration
For the namespace thing please look at below
resource_vsphere_supervisor.go under *_func resourceVsphereSupervisor() schema.Resource {_**
more say to be it dynamically so we can add multiple blocks
I Suggest to : 1) adding MinItems
For not having to call a function and maybe have it more organized, For you your judgment of course
Change the namespace scheme from:
To:
Also, you can take all of the blocks and create the schema in particular for each block and assign the element without having to have a return function that constructs the scheme back to the Elem key
Also if you would like to do so in addition you can create or have in the beginning some constant that will represent your resource keys/attributes and then use specKey whenever needed based on the scheme structure under the relevant schema
References
No response