Closed Miserlou closed 6 years ago
Hi @Miserlou,
First, I want to apologize for this crash and the manual work it created for you. I realize that when Terraform crashes it always harms your confidence in the product, especially when it leaves you in a bad state with resources that are not tracked. Responding to crashes with a prompt fix is a high priority for us because of the disruption they can cause.
I worked with the AWS provider maintainer team here and we found that this issue was reported in terraform-providers/terraform-provider-aws#3949 and subsequently fixed in AWS Provider version 1.13.0. Of course that doesn't change the fact that this crash affected you with the version you are currently running, and caused you to have to manually delete a lot of items that Terraform had already created.
We do the best we can to verify both Terraform Core and AWS provider releases, but due to the complexity of interacting with constantly-changing remote systems, unfortunately sometimes bugs like this creep in only after a release. In this particular case, the original behavior of the underlying ELB API masked a bug in the AWS provider that was discovered only after that behavior changed on the AWS side, exposing a lack of robustness in the provider's handling of the API responses.
As a result of this issue, the provider maintainer team has increased their vigilance for this class of bug when reviewing changes to the provider, to reduce the likelihood that future API changes will expose response parsing bugs. The team is also working through existing code to identify and fix previous bugs of this type. We have automated regression tests that run nightly in an attempt to catch regressions, though of course we can't necessarily anticipate how the API will change and so a combination of those tests and care during review are how we've responded to this problem.
Sorry again for the inconvenience caused by this crash. I believe upgrading to AWS Provider v1.13.0 or later will prevent thus problem from occurring for you again. Please let me know if you run into problems with that upgrade, and I'll ask the AWS provider team for their input.
@apparentlymart - thank you very much for your swift and thorough reply! Upgrading the provider version seems to have solved the issue.
provider "aws" {
version = "1.31.0"
region = "${var.region}"
}
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
Terraform Version
Debug Output
Crash Output
Expected Behavior
Don't crash.
Actual Behavior
Crashes every single time. Have to manually remove 99 items via the AWS console. Fuck this garbage stack. Fuck my life.
Steps to Reproduce
terraform apply