hashicorp / vagrant

Vagrant is a tool for building and distributing development environments.
https://www.vagrantup.com
Other
26.16k stars 4.43k forks source link

Fix ssh keyboard interactive login #13171

Closed natpicone closed 1 year ago

natpicone commented 1 year ago

The PR https://github.com/hashicorp/vagrant/pull/13052 has introduced the "keyboard-interactive" option for SSH connections. However, the order of preference is crucial, and when using this option, even if a valid SSH key is available, the connection still prompts for a password.

hashicorp-cla commented 1 year ago

CLA assistant check
All committers have signed the CLA.

natpicone commented 1 year ago

cc: @soapy1 @chrisroberts

stan-quinn commented 1 year ago

Shouldn't adding keyboard-interactive also obey a setting in ssh_config? I tried the current 2.3.6 release with an ssh_config including "KbdInteractiveAuthentication no", it had no effect. My publickey auth wasn't even tried, because it got stuck retrying keyboard-interactive.

chrisroberts commented 1 year ago

@natpicone Thanks for this PR! After further investigation I don't believe the original change (in #13052) was an appropriate modification based on the issue it was attempting to resolve. The root cause of the issue was an improperly configured Vagrant box. #13194 removes the keyboard-interactive authentication method, which should resolve the associated issues introduced by its addition.

Thanks again!