hashicorp / vagrant

Vagrant is a tool for building and distributing development environments.
https://www.vagrantup.com
Other
26.01k stars 4.42k forks source link

virtualbox version detection: handle WARNING lines #13394

Open paulcacheux opened 1 month ago

paulcacheux commented 1 month ago

As reported in https://www.virtualbox.org/ticket/22060, starting with Virtualbox 7.0.16 running:

$ vboxmanage --version
WARNING: Environment variable LOGNAME or USER does not correspond to effective user id.
7.0.18r162988

the warning line is written to stdout which is an issue since the parsing of the version is used in the provider code to use the correct class to handle following communication with Virtualbox.

This PR improves the version detection by parsing the version in the first line that does not start with WARNING:.

paulcacheux commented 1 month ago

@chrisroberts would you mind taking a look at this? Thanks a lot 👍