search

hashicorp / vault-client-go

HashiCorp Vault Go Client Library generated from OpenAPI spec.
Mozilla Public License 2.0
84 stars 17 forks source link

Sync OpenAPI; Multiple parameter correctness changes #206

Closed maxb closed 1 year ago

maxb commented 1 year ago

This includes the results of:

The general direction of change is pretty positive, but in reviewing the generated diffs, I have spotted an issue: we are now generating correct parameters for query parameters... but those query parameters are being handled as individual function parameters... which are generated in the order listed in the OpenAPI spec... which is dependent on random Go hash iteration ordering. Ugh.

Oh well, let's catch up with latest developments in the Vault repo for now, and I'll go put in a new PR to at least sort the parameters alphabetically.

Longer term, this is probably going to push us in the direction of excluding the GET version of APIs with equivalent GET and POST versions from the generated libraries.

averche commented 1 year ago

Longer term, this is probably going to push us in the direction of excluding the GET version of APIs with equivalent GET and POST versions from the generated libraries.

We can definitely do that. As a library user, I would rather want just the a single "recommended" method exposed to me rather than having to guess which one to use.