search

hashicorp / vault-helm

Helm chart to install Vault and other associated components.
Mozilla Public License 2.0
1.06k stars 869 forks source link

Allow additional annotations for standby and active services via config #896

Closed tekicat closed 9 months ago

tekicat commented 1 year ago

Revival of https://github.com/hashicorp/vault-helm/pull/546

Currently there is no ability to annotate services for active and standby services, as they inherit their settings from the main server service configuration. This is a problem, when you need to attach different annotations to the different services. Instead of just allowing for setting of annotations, I opted to allow configuring the services for more flexibility.

Helps to close https://github.com/hashicorp/vault-helm/issues/674

Partially resolves https://github.com/hashicorp/vault-helm/issues/588

Thanks @jamesgoodhouse

hashicorp-cla commented 1 year ago

CLA assistant check
All committers have signed the CLA.

tekicat commented 1 year ago

Hey @tomhjp , @tvoran Would appreciate your inputs, thanks!

chris-ng-scmp commented 10 months ago

This is a must have feature for Vault HELM chart to set difference annotations for individual services, how long we can see this appoved?

tekicat commented 9 months ago

Thanks for the suggestions @kschoche , they looked good and I have applied them. :)