search

hashicorp / vault-helm

Helm chart to install Vault and other associated components.
Mozilla Public License 2.0
1.08k stars 873 forks source link

Fix syntax for actionlint workflow #903

Closed tomhjp closed 1 year ago

tomhjp commented 1 year ago

See https://github.com/hashicorp/vault-helm/actions/runs/5122269586 for an example error.

tvoran commented 1 year ago

IIRC actionlint doesn't support composite actions (https://github.com/rhysd/actionlint/issues/46). Is there a way to ignore the setup-test-tools action in this repo?

tomhjp commented 1 year ago

IIRC actionlint doesn't support composite actions. Is there a way to ignore the setup-test-tools action in this repo?

Thanks for pointing that issue out. I moved the composite action out into its own actions sub-folder within .github to fix this. The linter only checks .github/workflows and the action uses a slightly different syntax to workflows, so it seems reasonable to give it its own folder anyway.

tomhjp commented 1 year ago

Thanks!